Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(divider): S2 migration #3557

Open
wants to merge 1 commit into
base: spectrum-two
Choose a base branch
from
Open

feat(divider): S2 migration #3557

wants to merge 1 commit into from
+84 −72

Conversation

cdransf
Copy link
Member

@cdransf cdransf commented Feb 13, 2025

Description

CSS-708

This migrates the divider component to S2. Custom properties have been remapped and updated per the design spec.

New properties

--spectrum-divider-horizontal-minimum-width
--spectrum-divider-vertical-minimum-height

New mods

--mod-divider-inline-minimum-size
--mod-divider-block-minimum-size

Removed mods

--mod-divider-background-color-large-static-black
--mod-divider-background-color-large-static-white
--mod-divider-background-color-medium-static-black
--mod-divider-background-color-medium-static-white
--mod-divider-background-color-small-static-black
--mod-divider-background-color-small-static-white

Additions

This adds new minimum width and height tokens for the divider and the minDimensionValues arg has been removed in favor of these tokens and the rules with which they're applied.

The default size for the Storybook control has been changed to medium (the new default size for the component). All sizes are now displayed for the static color variants in the docs.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@cdransf cdransf added size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-for-review labels Feb 13, 2025
@cdransf cdransf self-assigned this Feb 13, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: e811287

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@spectrum-css/divider Major
@spectrum-css/alertbanner Major
@spectrum-css/alertdialog Major
@spectrum-css/dialog Major
@spectrum-css/menu Major
@spectrum-css/popover Major
@spectrum-css/tray Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cdransf cdransf force-pushed the cdransf/s2-divider-migration branch from ed77498 to 7883943 Compare February 13, 2025 21:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

File metrics

Summary

Total size: 1.42 MB*
Total change (Δ): 🟢 ⬇ 0.37 KB (-0.02%)

Table reports on changes to a package's main file.

Package Size Minified Gzipped Δ
divider 2.85 KB - - 🟢 ⬇ 0.37 KB

divider

Filename Head Minified Gzipped Compared to base
index.css 2.85 KB - - 🟢 ⬇ 0.37 KB
metadata.json 1.44 KB - - 🟢 ⬇ 0.23 KB
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

🚀 Deployed on https://pr-3557--spectrum-css.netlify.app

cdransf
cdransf commented Feb 13, 2025
View reviewed changes
components/divider/dist/metadata.json
],
"modifiers": [
"--mod-divider-background-color",
"--mod-divider-background-color-large-static-black",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This drops deprecated color styles in favor of the tokens specified by design — I'm not sure if we should alias the raw color tokens to our own and — if so — what naming scheme to use? Doing so would allow us to provide mods for them, but I'm not sure if that's necessary.

@castastrophe castastrophe added the S2 Spectrum 2 label Feb 18, 2025
@cdransf cdransf force-pushed the cdransf/s2-divider-migration branch 2 times, most recently from 21cf5df to 4eb24b0 Compare February 21, 2025 23:42
@castastrophe castastrophe force-pushed the spectrum-two branch 5 times, most recently from d5e72d4 to 0f14273 Compare February 24, 2025 22:39
@cdransf cdransf force-pushed the cdransf/s2-divider-migration branch from 4eb24b0 to e811287 Compare February 25, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jawinn jawinn Awaiting requested review from jawinn

@rise-erpelding rise-erpelding Awaiting requested review from rise-erpelding

@marissahuysentruyt marissahuysentruyt Awaiting requested review from marissahuysentruyt

At least 1 approving review is required to merge this pull request.

Assignees

@cdransf cdransf

Labels
ready-for-review S2 Spectrum 2 size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdransf @castastrophe